Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for ASP.NET Razor #3064

Merged
merged 5 commits into from Sep 15, 2021
Merged

Conversation

@RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Sep 2, 2021

This resolves #1225.

image


Man, this was difficult. CSHTML is incredibly context-sensitive, so I had to write something pretty close to a parser. I think it turned out ok in the end but the whole language definition is still pretty complex.

@github-actions
Copy link

@github-actions github-actions bot commented Sep 2, 2021

JS File Size Changes (gzipped)

A total of 3 files have changed, with a combined diff of +1.02 KB (+21.8%).

file master pull size diff % diff
components/prism-cshtml.min.js 0 Bytes 994 B +994 B +100.0%
plugins/autoloader/prism-autoloader.min.js 2.26 KB 2.27 KB +16 B +0.7%
plugins/show-language/prism-show-language.min.js 2.44 KB 2.46 KB +15 B +0.6%

Generated by 🚫 dangerJS against de3c8a0

Loading

@RunDevelopment
Copy link
Member Author

@RunDevelopment RunDevelopment commented Sep 2, 2021

Also, since MS seems to let VBHTML die, I will not add support for it.

I was unable to find sufficient documentation for the language variant. MS has exactly one page of documentation for VBHTML last updated 7 years ago. However, from that page, I can see that VBHTML is even more context-sensitive than CSHTML and will most likely require an even more complex grammar.

I do not wish to put time and effort into creating and maintaining the grammar of a poor-documented, dying, incredibly complex language.

Loading

@RunDevelopment RunDevelopment merged commit 4433ccf into PrismJS:master Sep 15, 2021
11 checks passed
Loading
@RunDevelopment RunDevelopment deleted the issue1225 branch Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant