Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ReDoS #3078

Merged
merged 3 commits into from Sep 15, 2021
Merged

Fix ReDoS #3078

merged 3 commits into from Sep 15, 2021

Conversation

@ready-research
Copy link
Contributor

@ready-research ready-research commented Sep 14, 2021

Fix ReDoS

* [Security] Fix ReDoS

Fix ReDoS
@github-actions
Copy link

@github-actions github-actions bot commented Sep 14, 2021

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of +5 B (+0.5%).

file master pull size diff % diff
components/prism-markup.min.js 1.03 KB 1.04 KB +5 B +0.5%

Generated by 🚫 dangerJS against 243390e

Loading

@RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Sep 14, 2021

components/prism-markup.min.js has a new line at the end for some reason. That's why the build fails.

Loading

@ready-research
Copy link
Contributor Author

@ready-research ready-research commented Sep 14, 2021

@RunDevelopment Is it okay now?
Please validate the huntr link by clicking on mark as valid, and also you can confirm the fix. Thank you.

Loading

@RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Sep 14, 2021

@ready-research That new line is still present. Your last commit was empty.

Loading

@ready-research
Copy link
Contributor Author

@ready-research ready-research commented Sep 15, 2021

@RunDevelopment I am not seeing any new line in components/prism-markup.min.js. Can you please edit that if you have permission to do that? Or feel free to raise a new pull to resolve this issue. Thank you.

Loading

@RunDevelopment RunDevelopment merged commit 0ff371b into PrismJS:master Sep 15, 2021
11 checks passed
Loading
@ready-research
Copy link
Contributor Author

@ready-research ready-research commented Sep 15, 2021

@RunDevelopment Can you please confirm the fix in huntr?

Loading

@RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Sep 15, 2021

Done :)

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants