Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose highlightLines as Prism.plugins.highlightLines in that plugin #3086

Merged
merged 2 commits into from Sep 23, 2021

Conversation

manutepowa
Copy link
Contributor

@manutepowa manutepowa commented Sep 19, 2021

I have made a pull request with reference to this issue #1093

I have added the highlightLines function with the Prism plugin structure.

I hope it will be helpful
Thanks

@github-actions
Copy link

@github-actions github-actions bot commented Sep 19, 2021

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of +19 B (+1.3%).

file master pull size diff % diff
plugins/line-highlight/prism-line-highlight.min.js 1.45 KB 1.47 KB +19 B +1.3%

Generated by 🚫 dangerJS against d32f1f1

@RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Sep 19, 2021

Thank you for the PR @manutepowa!

I think it's good as is. Just one thing: Prism has a kinda weird build system, so you have to rebuild Prism and commit the changes. Just run npm ci && npm run build and commit the changes to plugins/line-highlight/prism-line-highlight.min.js.

@manutepowa
Copy link
Contributor Author

@manutepowa manutepowa commented Sep 19, 2021

Sorry @RunDevelopment
I have just made a new change by fixing rebuild.

Is it correct now ?

Thanks

@RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Sep 23, 2021

Sorry for the delay @manutepowa!

Sorry @RunDevelopment

There's nothing to be sorry about! Thank you for taking the time to contribute to this project!

@RunDevelopment RunDevelopment merged commit 9f4c0e7 into PrismJS:master Sep 23, 2021
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants