Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS: Added properties #3099

merged 3 commits into from Oct 10, 2021

JS: Added properties #3099

merged 3 commits into from Oct 10, 2021


Copy link

@RunDevelopment RunDevelopment commented Sep 30, 2021

This PR adds properties to JS.


Property highlighting is split in string properties (e.g. { "foo": null }) and literal properties (e.g. { foo: null }). This distinction is important because we cannot support literal properties in more complex languages like TS. These languages are just too complex. However, we can support string properties in TS

Fix resolves #2336.
Closes #2004.

Copy link

@github-actions github-actions bot commented Sep 30, 2021

JS File Size Changes (gzipped)

A total of 4 files have changed, with a combined diff of +144 B (+5.3%).

file master pull size diff % diff
components/prism-actionscript.min.js 478 B 508 B +30 B +6.3%
components/prism-javascript.min.js 1.5 KB 1.57 KB +76 B +5.1%
components/prism-tsx.min.js 192 B 212 B +20 B +10.4%
components/prism-typescript.min.js 558 B 576 B +18 B +3.2%

Generated by 🚫 dangerJS against 8db638c

@RunDevelopment RunDevelopment merged commit 3b2238f into PrismJS:master Oct 10, 2021
11 checks passed
@RunDevelopment RunDevelopment deleted the issue2336 branch Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

1 participant