Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elm: Recognise unicode escapes as valid Char #3105

Merged
merged 5 commits into from Oct 3, 2021

Conversation

hoonweiting
Copy link
Contributor

@hoonweiting hoonweiting commented Oct 3, 2021

Elm recognises unicode escapes from '\u{0000}' to '\u{10FFFF}' as valid Char. Not sure if the regex I modified is the best way to do it though!

@github-actions
Copy link

@github-actions github-actions bot commented Oct 3, 2021

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of +5 B (+0.8%).

file master pull size diff % diff
components/prism-elm.min.js 596 B 601 B +5 B +0.8%

Generated by 🚫 dangerJS against fba86d0

Copy link
Member

@RunDevelopment RunDevelopment left a comment

Thanks for the PR @hoonweiting!

Only one nit!

components/prism-elm.js Outdated Show resolved Hide resolved
hoonweiting and others added 2 commits Oct 3, 2021
Co-authored-by: Michael Schmidt <msrd0000@gmail.com>
@RunDevelopment RunDevelopment merged commit 736c581 into PrismJS:master Oct 3, 2021
11 checks passed
@RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Oct 3, 2021

Thank you for contributing @hoonweiting!

@hoonweiting hoonweiting deleted the elm-char branch Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants