Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar: Ensure toolbar is visible across themes #3163

Merged
merged 1 commit into from Oct 24, 2021

Conversation

hoonweiting
Copy link
Contributor

@hoonweiting hoonweiting commented Oct 24, 2021

#3161 sets the z-index of the code element (in pre elements) to 1 to ensure Coy's shadows are visible. However, this will cause the toolbar to be set underneath the code. Instead of setting the z-index of the Toolbar to something higher for Coy only, this PR takes a step back and sets the z-index of the Toolbar to 10 by default, so all other themes can also benefit.

Based on #3161 (comment)

@github-actions
Copy link

@github-actions github-actions bot commented Oct 24, 2021

No JS Changes

Generated by 🚫 dangerJS against 9dd9ac9

@RunDevelopment RunDevelopment merged commit 1cac355 into PrismJS:master Oct 24, 2021
12 checks passed
@hoonweiting hoonweiting deleted the toolbar-z-index branch Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants