Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAXScript: Various improvements #3181

Merged

Conversation

RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Nov 9, 2021

Changes:

  • Fixed constant vs color confusion. Seems like I swapped the regex at some point...
  • Made on and off keywords instead of booleans. This is closer to how the language interprets code and makes it easier to implement function calls.
  • Added function calls (as requested by @I-d-as). The detected syntax is intentionally restrictive to prevent false positives. This leads to a few false negatives (e.g. around case statements) but I think that's okay for now.

Example:

image

@github-actions
Copy link

@github-actions github-actions bot commented Nov 9, 2021

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of +142 B (+20.2%).

file master pull size diff % diff
components/prism-maxscript.min.js 702 B 844 B +142 B +20.2%

Generated by 🚫 dangerJS against b3ff370

@RunDevelopment RunDevelopment merged commit e9b856c into PrismJS:master Nov 22, 2021
12 checks passed
@RunDevelopment RunDevelopment deleted the maxscript-improvements branch Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant