Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zig: Use standard char token #3264

Merged
merged 1 commit into from Dec 9, 2021
Merged

Conversation

RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Dec 2, 2021

Changes:

  • Added char token
  • Renamed builtin-types -> builtin-type

@github-actions
Copy link

@github-actions github-actions bot commented Dec 2, 2021

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of +3 B (+0.3%).

file master pull size diff % diff
components/prism-zig.min.js 1.17 KB 1.17 KB +3 B +0.3%

Generated by 🚫 dangerJS against 22fc701

Copy link
Contributor

@hoonweiting hoonweiting left a comment

Looking at the keyword reference for the latest stable version (0.8.1), I think there are three new keywords: anyframe, anytype, and nosuspend. Since this PR is focused on using the char token and does not touch the keyword token at all, should adding these keywords be part of another PR instead? If so, then I think this PR is ready to go!

@RunDevelopment
Copy link
Member Author

@RunDevelopment RunDevelopment commented Dec 9, 2021

I think there are three new keywords: anyframe, anytype, and nosuspend

Good catch! I made a separate PR for that (#3279).

@RunDevelopment RunDevelopment merged commit c3f9fb7 into PrismJS:master Dec 9, 2021
12 checks passed
@RunDevelopment RunDevelopment deleted the issue3170-zig branch Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants