Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSIS: Update Regex pattern for variables #3266

Merged
merged 7 commits into from Dec 4, 2021
Merged

Conversation

idleberg
Copy link
Contributor

@idleberg idleberg commented Dec 4, 2021

Unless at the beginning of a variable name, variables in NSIS may contain the .-character (see example).

Changes:

  • update Regex pattern for variables to support dots
  • add test for the above

@github-actions
Copy link

@github-actions github-actions bot commented Dec 4, 2021

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of +4 B (+0.2%).

file master pull size diff % diff
components/prism-nsis.min.js 2.02 KB 2.02 KB +4 B +0.2%

Generated by 🚫 dangerJS against b352154

Copy link
Member

@RunDevelopment RunDevelopment left a comment

Thank you for the PR @idleberg!

components/prism-nsis.js Outdated Show resolved Hide resolved
@RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Dec 4, 2021

Please also resolve the merge conflict.

@RunDevelopment RunDevelopment merged commit adcc878 into PrismJS:master Dec 4, 2021
12 checks passed
@RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Dec 4, 2021

Thank you for contributing @idleberg!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants