Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSIS: Update Regex for constants pattern #3267

merged 2 commits into from Dec 4, 2021


Copy link

@idleberg idleberg commented Dec 4, 2021

Similar to #3266, the constant patterns needs to be updated to support !-characters. While this is, arguably, highly unreadable, it's valid code shown in this example (take note of the line ${!defineifexist} var_name file_name).


  • update Regex pattern for constants to support exclamation marks
  • add test for the above

Copy link

@github-actions github-actions bot commented Dec 4, 2021

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of +1 B (+0.0%).

file master pull size diff % diff
components/prism-nsis.min.js 2.02 KB 2.02 KB +1 B +0.0%

Generated by 🚫 dangerJS against f8b2817

@idleberg idleberg changed the title NSIS: Add test for new constants Regex pattern NSIS: Update Regex for constants pattern Dec 4, 2021
@RunDevelopment RunDevelopment merged commit 55583fb into PrismJS:master Dec 4, 2021
12 checks passed
Copy link

@RunDevelopment RunDevelopment commented Dec 4, 2021

Thank you for contributing @idleberg!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants