New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register as .zip/.mrpack handler on macOS and Linux #229
Conversation
Signed-off-by: Ryan Cao <70191398+ryanccn@users.noreply.github.com>
Signed-off-by: Ryan Cao <70191398+ryanccn@users.noreply.github.com>
added experimental Linux support! |
Perhaps I could add Windows support...? |
Perhaps |
Can anyone test Windows? |
d c o |
This seriously makes me want to drop Windows support |
On Linux, packagers will have to register the |
registering a mime type on linux is usually simple and done with
(presuming Modrinth get a .mrpack icon someday) with a config file according to https://specifications.freedesktop.org/shared-mime-info-spec/shared-mime-info-spec-latest.html <?xml version="1.0" encoding="UTF-8"?>
<mime-info xmlns="http://www.freedesktop.org/standards/shared-mime-info">
<mime-type type="application/x-modrinth-modpack+zip">
<comment>Modrinth Modpack File</comment>
<icon name="application-x-modrinth-modpack"/>
<glob-deleteall/>
<glob pattern="*.mrpack"/>
</mime-type>
</mime-info> and then install that with
package system hooks usually take care of running I think we should provide the xml file but packagers will need to install it correctly |
Signed-off-by: Ryan Cao <70191398+ryanccn@users.noreply.github.com>
DCO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EDIT: Ignore me, I didn't see the prior conversation
review wen :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review now
Signed-off-by: Ryan Cao <70191398+ryanccn@users.noreply.github.com>
Uh I think you forgor to push the changes 💀 |
As cool as it seems, doesn't it create more confusion than necessary? What if the user opens a resource pack? Datapack? Texture pack? (aka something pre-1.6) |
Oops- |
review wen |
Seems like ECM has an API for registering MIME info, I'll look into it sometime this week 😊 |
need some help with this |
Signed-off-by: Ryan Cao <70191398+ryanccn@users.noreply.github.com>
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Enables opening
mrpack
s andzip
s directly via Open with... and importing. Also enables dragging and dropping on the Dock icon to import.Also makes nice looking file icons like this for
mrpack
s: