-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for WinUI 3 #2393
Add support for WinUI 3 #2393
Conversation
b00c0d1
to
cc3e8b2
Compare
cc3e8b2
to
43e5f7d
Compare
@@ -79,6 +104,18 @@ jobs: | |||
vmImage: $(MacImage) | |||
workspace: | |||
clean: all | |||
|
|||
variables: | |||
disable_package_restore_step: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is required to ensure the package resolution logic matches the build. I think it should be done for all targets (dotnet build does this now anyways).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original intent of the separate process was to be able to more clearly look in the logs for package restoration issues vs build issues... however with how unreliable the NuGet task can be at times I'm not opposed to normalizing on having msbuild / dotnet cli handling the restore for us
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me... easiest 200 file review I've had to do in a long time 🤣
43e5f7d
to
b0a07ab
Compare
Description of Change
Adds support for WinUI 3 (Prism.Uno.WinUI and associated)
API Changes
None.
Behavioral Changes
PR Checklist