Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CodeChecker for PHP #22

Closed
4 tasks done
rugk opened this issue Jul 9, 2016 · 9 comments
Closed
4 tasks done

Add CodeChecker for PHP #22

rugk opened this issue Jul 9, 2016 · 9 comments
Assignees
Milestone

Comments

@rugk
Copy link
Member

rugk commented Jul 9, 2016

@rugk
There are several code checkers for PHP files. So why not add them?


@rugk
For adding this repo to https://insight.sensiolabs.com/ one must be the owner of the repo. Therefore, @elrido you have to do this. It's basically just a few clicks.


@rugk
For https://scrutinizer-ci.com too.


@rugk

In codeclimate.com I cannot change the settings, but at least here is an analysis: https://codeclimate.com/github/elrido/ZeroBin Code Climate
The score is so bad, because the JS are not excluded from analysis yet.

@rugk rugk added this to the Next release milestone Jul 9, 2016
@rugk
Copy link
Member Author

rugk commented Jul 9, 2016

I updated the badges, but there is still something to do:

  • CodeClimate coverage badge does not work right now. I think the coverage must somehow pushed to it. Or is it possibly Travis-related? Travis is not setup right now?
  • Scrutinizer-Ci - Can we get a link @elrido ?
  • And SensioLabsInside is still a ToDo.

@elrido
Copy link
Contributor

elrido commented Jul 9, 2016

@elrido
Copy link
Contributor

elrido commented Jul 9, 2016

AFAIK this is now done. Let me know if anything is missing or close it if its fine for you, too.

@rugk
Copy link
Member Author

rugk commented Jul 9, 2016

Yes, all done. I also added all the badges.

@rugk rugk closed this as completed Jul 9, 2016
@rugk
Copy link
Member Author

rugk commented Jul 9, 2016

BTW it's interesting to see how much the coverage varies depending on which service analyses it.

@rugk
Copy link
Member Author

rugk commented Jul 9, 2016

Wait no, https://insight.sensiolabs.com is missing...

@rugk rugk reopened this Jul 9, 2016
@elrido
Copy link
Contributor

elrido commented Jul 9, 2016

Is it because the project was marked private? I just changed that...

@rugk
Copy link
Member Author

rugk commented Jul 9, 2016

Yes, think so. I found it. However I cannot access any settings (is there the possibility to add another user?). I cannot even access the badge code, so it would be nice if you could place the badge there.
BTW pretty serious things it reports with the potentially SQL injection. I'll open an issue for it.

@elrido
Copy link
Contributor

elrido commented Jul 9, 2016

It says: "Collaborators: Upgrade to a Business plan to be able to share your analyses."

And these "SQL injections" could only be triggered by editing the config file. It's the table prefix it complains about.

Here is the badge code for future reference:
[![SensioLabsInsight](https://insight.sensiolabs.com/projects/57c9e74e-c6f9-4de6-a876-df66ec2ea1ff/mini.png)](https://insight.sensiolabs.com/projects/57c9e74e-c6f9-4de6-a876-df66ec2ea1ff)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants