New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dragon breath ability casues OOS #8

Closed
gfgtdf opened this Issue Jun 17, 2017 · 6 comments

Comments

Projects
None yet
3 participants
@gfgtdf

gfgtdf commented Jun 17, 2017

This abilities implementation assumes that the defender and attacker are facing each other during an attack. But the facing is set by the drawing code and will not be executed if 'Show Fights' is disabled in the preferences.

EDIT: this probaqbly effects 'skip replay' when joining a game aswell, not sure though.

EDIT2: this might effect other abilities aswell.

@ProditorMagnus

This comment has been minimized.

Show comment
Hide comment
@ProditorMagnus

ProditorMagnus Jun 17, 2017

Owner

I noticed in todays game that sometimes units behind dragon get damaged, instead of units behind other unit.

Owner

ProditorMagnus commented Jun 17, 2017

I noticed in todays game that sometimes units behind dragon get damaged, instead of units behind other unit.

@gfgtdf

This comment has been minimized.

Show comment
Hide comment
@gfgtdf

gfgtdf Jun 17, 2017

did you one of the thigs i mentioned above?

In any case this should be fixed.

gfgtdf commented Jun 17, 2017

did you one of the thigs i mentioned above?

In any case this should be fixed.

@ProditorMagnus

This comment has been minimized.

Show comment
Hide comment
@ProditorMagnus

ProditorMagnus Jun 17, 2017

Owner

I think I started observing that game at turn 1, so not that. I have not used skip fights, so that has whatever its default is.

Owner

ProditorMagnus commented Jun 17, 2017

I think I started observing that game at turn 1, so not that. I have not used skip fights, so that has whatever its default is.

@gfgtdf

This comment has been minimized.

Show comment
Hide comment
@gfgtdf

gfgtdf Jul 13, 2017

This is still an open issue. Do you inted to fix this or are you going to wait for wesnoth 1.14 ?

gfgtdf commented Jul 13, 2017

This is still an open issue. Do you inted to fix this or are you going to wait for wesnoth 1.14 ?

@ProditorMagnus

This comment has been minimized.

Show comment
Hide comment
@ProditorMagnus

ProditorMagnus Jul 13, 2017

Owner

I messaged inferno8 about it, I dont intend to personally fix this.

Owner

ProditorMagnus commented Jul 13, 2017

I messaged inferno8 about it, I dont intend to personally fix this.

@sevu sevu added this to the 4.19 milestone Oct 18, 2017

@ProditorMagnus ProditorMagnus added the EoMa label Feb 6, 2018

@ProditorMagnus

This comment has been minimized.

Show comment
Hide comment
@ProditorMagnus

ProditorMagnus Mar 9, 2018

Owner

When fixing this I noticed that when dragons breath+landing starts killing each other, they keep getting killed until map is full of parachute dwarves (or C stack overflows).

Owner

ProditorMagnus commented Mar 9, 2018

When fixing this I noticed that when dragons breath+landing starts killing each other, they keep getting killed until map is full of parachute dwarves (or C stack overflows).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment