Make tests compatible with PHPUnit 4 and 6 #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the PHPUnit4And6Compat trait from MediaWiki core to make PHPUnit 4 methods work even when being run with PHPUnit 6. If it's being run with an older MediaWiki core version, define a empty trait in the bootstrap to avoid fatal errors. Since the lack of the trait means we're running with PHPUnit 4, everything should work out.
|
Thanks! |
|
Aaahhh. I should have checked the test output first.
|
|
Like I said on wikitech-l, that's a pre-existing problem on master, before my PR. |
|
Oh, had not seen your mail yet. Indeed on current master they are not running, which is the issue I want to fix. This issue has been there since I switched the tests to PHPUnit 6.x+ format. Before that they ran fine https://travis-ci.org/JeroenDeDauw/Maps/builds/363977529 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the PHPUnit4And6Compat trait from MediaWiki core to make PHPUnit 4
methods work even when being run with PHPUnit 6. If it's being run with
an older MediaWiki core version, define a empty trait in the bootstrap
to avoid fatal errors. Since the lack of the trait means we're running
with PHPUnit 4, everything should work out.