Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance upsampling layer #1122

Merged
merged 2 commits into from Oct 20, 2020
Merged

enhance upsampling layer #1122

merged 2 commits into from Oct 20, 2020

Conversation

wyli
Copy link
Member

@wyli wyli commented Oct 19, 2020

part of #722
breaking changes (names of mode changed) for

  • SegResNet
  • SegResNetVAE

Status

Ready

Types of changes

  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli requested review from yiheng-wang-nv, ericspod and Nic-Ma and removed request for yiheng-wang-nv and ericspod October 19, 2020 16:55
@wyli
enhance upsampling layer
4eef561 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli added this to In progress in v0.4.0 via automation Oct 19, 2020
@Nic-Ma
Copy link
Contributor

Nic-Ma commented Oct 20, 2020

Hi @yiheng-wang-nv ,

Could you please help review this PR as you developed the original network?
Thanks.

yiheng-wang-nv
yiheng-wang-nv approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@yiheng-wang-nv yiheng-wang-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Wenqi. I think the changes are correct.

@wyli wyli merged commit 840ffad into Project-MONAI:master Oct 20, 2020
v0.4.0 automation moved this from In progress to Done Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiheng-wang-nv yiheng-wang-nv yiheng-wang-nv approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

@ericspod ericspod Awaiting requested review from ericspod

Assignees
No one assigned
Labels
None yet
Projects
No open projects
v0.4.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wyli @Nic-Ma @yiheng-wang-nv