-
Notifications
You must be signed in to change notification settings - Fork 1.4k
2525 Add decollate logic to DeepGrow module (8/July) #2530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
merge master
merge master
merge master
Signed-off-by: Nic Ma <nma@nvidia.com>
|
Hi @wyli @SachidanandAlle , There is a potential issue in this PR that I am not very sure how to fix and want to discuss with you guys here: Can we pad the data and collate? Or any other idea to avoid Thanks in advance. |
|
/black |
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
|
This fix looks ok to me.. we can Vish to verify sample 2D deepgrow training.. for accuracy |
Hi @SachidanandAlle , Thanks for your review, do you mean to use Thanks in advance. |
Signed-off-by: Nic Ma <nma@nvidia.com>
|
/black |
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
|
Hi @wyli , Thanks for @SachidanandAlle 's analysis and help, this PR is ready for review now. Thanks in advance. |
Signed-off-by: Nic Ma <nma@nvidia.com>
wyli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good according to @SachidanandAlle
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Fixes #2525 .
Description
This PR updated the DeepGrow module based on the latest decollate logic.
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.