Skip to content

Conversation

@Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Jul 6, 2021

Fixes #2525 .

Description

This PR updated the DeepGrow module based on the latest decollate logic.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma Nic-Ma requested review from wyli and yiheng-wang-nv July 6, 2021 09:46
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jul 6, 2021

Hi @wyli @SachidanandAlle ,

There is a potential issue in this PR that I am not very sure how to fix and want to discuss with you guys here:
As DeepGrow is slightly different from regular training, it needs to run several iterations inference / interactions, so we need to inference -> decollate -> click transforms -> collate -> inference as what I changed in this PR.
But some random click transforms may output data with different size, so we can't collate them into a batch for next inference, like the "guidance" generated by AddRandomGuidanced here: https://github.com/Project-MONAI/tutorials/blob/master/deepgrow/ignite/train.py#L98

Can we pad the data and collate? Or any other idea to avoid collate?

Thanks in advance.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jul 6, 2021

/black

Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
@SachidanandAlle
Copy link
Contributor

This fix looks ok to me.. we can Vish to verify sample 2D deepgrow training.. for accuracy

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jul 6, 2021

This fix looks ok to me.. we can Vish to verify sample 2D deepgrow training.. for accuracy

Hi @SachidanandAlle ,

Thanks for your review, do you mean to use pad_collate to solve the size issue when collating again?
@wyli @rijobro what do you guys think?

Thanks in advance.

Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jul 6, 2021

/black

@deepib deepib changed the title [WIP] 2525 Add decollate logic to DeepGrow module [WIP] 2525 Add decollate logic to DeepGrow module (8/July) Jul 6, 2021
Nic-Ma added 6 commits July 6, 2021 23:35
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma Nic-Ma changed the title [WIP] 2525 Add decollate logic to DeepGrow module (8/July) 2525 Add decollate logic to DeepGrow module (8/July) Jul 6, 2021
@Nic-Ma Nic-Ma marked this pull request as ready for review July 6, 2021 23:46
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jul 6, 2021

Hi @wyli ,

Thanks for @SachidanandAlle 's analysis and help, this PR is ready for review now.
Could you please help also review it?

Thanks in advance.

Signed-off-by: Nic Ma <nma@nvidia.com>
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good according to @SachidanandAlle

Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma Nic-Ma enabled auto-merge (squash) July 7, 2021 00:00
@Nic-Ma Nic-Ma merged commit c6793fd into Project-MONAI:dev Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deepgrow Interaction is not compatiable with decollate_batch for v 0.6.0 (8/July)

4 participants