Skip to content

Conversation

@Borda
Copy link
Contributor

@Borda Borda commented Sep 24, 2021

Description

Update Python notation to be better suitable to python 3.6+
in fact, I have just used the pyupgrade nook in pre-commit

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Borda Borda force-pushed the pyupgrade branch 3 times, most recently from ef11b09 to 3e5dc92 Compare September 24, 2021 22:31
Signed-off-by: Jirka <jirka.borovec@seznam.cz>
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the goal is to do this kind of commit automatically in the future, not sure whether it is compatible with the other code formatting tools. But the current changes look good. We can experiment it with the development branch for a while first

Signed-off-by: Jirka <jirka.borovec@seznam.cz>
@Borda
Copy link
Contributor Author

Borda commented Sep 25, 2021

not sure whether it is compatible with the other code formatting tools

it shall be and another case it shall be caught by your CI :]

@wyli
Copy link
Contributor

wyli commented Sep 25, 2021

/integration-test
/black

Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, thanks!

@wyli wyli merged commit a477905 into Project-MONAI:dev Sep 25, 2021
@Borda Borda deleted the pyupgrade branch September 25, 2021 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants