Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

40 mean_dice metric #66

Merged
merged 10 commits into from
Feb 10, 2020
Merged

40 mean_dice metric #66

merged 10 commits into from
Feb 10, 2020

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Feb 8, 2020

Fixes #40 .

Description

Add support to compute mean_dice metric during validation or evaluation.

Status

Ready

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or new feature that would cause existing functionality to change)
  • New tests added to cover the changes
  • Docstrings/Documentation updated

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 10, 2020

Hi @ericspod , @wyli , @atbenmurray ,

I already added all features of MeanDice metric and unit tests in this PR.
Could you please help review it?
Thanks.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 10, 2020

Hi @IsaacYangSLA ,

The CI test failed in multi-gpu test case due to:
test_multi_gpu (tests.test_parallel_execution.TestParallelExecution) ... Current run is terminating due to exception: CUDA error: out of memory
Could you please help take a look?
Thanks.

@wyli
Copy link
Contributor

wyli commented Feb 10, 2020

@ericspod this PR is ready for review (ci pipeline failed because of a testing server issue, we are working on a fix)

monai/utils/to_onehot.py Outdated Show resolved Hide resolved
@wyli wyli requested a review from ericspod February 10, 2020 17:16
@wyli wyli merged commit f430475 into master Feb 10, 2020
@wyli wyli mentioned this pull request Feb 11, 2020
3 tasks
@wyli wyli deleted the 40-meandice-metric branch April 6, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MVP example for model validation every N training steps
3 participants