From 13d8faefc829432a58607973ca3e9ea5e220f605 Mon Sep 17 00:00:00 2001 From: Eric Kerfoot Date: Wed, 20 Nov 2024 17:52:31 +0000 Subject: [PATCH 1/2] Fixing a minor bug in a test Signed-off-by: Eric Kerfoot --- tests/test_module_list.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/test_module_list.py b/tests/test_module_list.py index d21ba53b7c..5a6f9970d9 100644 --- a/tests/test_module_list.py +++ b/tests/test_module_list.py @@ -58,13 +58,17 @@ def test_transform_api(self): continue with self.subTest(n=n): basename = n[:-1] # Transformd basename is Transform + + # remove aliases to check, do this before the assert below so that a failed assert does skip this + for postfix in ("D", "d", "Dict"): + remained.remove(f"{basename}{postfix}") + for docname in (f"{basename}", f"{basename}d"): if docname in to_exclude_docs: continue if (contents is not None) and f"`{docname}`" not in f"{contents}": self.assertTrue(False, f"please add `{docname}` to docs/source/transforms.rst") - for postfix in ("D", "d", "Dict"): - remained.remove(f"{basename}{postfix}") + self.assertFalse(remained) From cdf434181eb7a3aeb38278b4d929bedecad218b8 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Wed, 20 Nov 2024 17:54:17 +0000 Subject: [PATCH 2/2] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- tests/test_module_list.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_module_list.py b/tests/test_module_list.py index 5a6f9970d9..833441cbca 100644 --- a/tests/test_module_list.py +++ b/tests/test_module_list.py @@ -68,7 +68,7 @@ def test_transform_api(self): continue if (contents is not None) and f"`{docname}`" not in f"{contents}": self.assertTrue(False, f"please add `{docname}` to docs/source/transforms.rst") - + self.assertFalse(remained)