diff --git a/tests/IntegrationTests/WorkflowExecutor.IntegrationTests/Features/TaskStatusUpdate.feature b/tests/IntegrationTests/WorkflowExecutor.IntegrationTests/Features/TaskStatusUpdate.feature index 9a0a9b5e4..c83331f61 100644 --- a/tests/IntegrationTests/WorkflowExecutor.IntegrationTests/Features/TaskStatusUpdate.feature +++ b/tests/IntegrationTests/WorkflowExecutor.IntegrationTests/Features/TaskStatusUpdate.feature @@ -61,7 +61,6 @@ Scenario Outline: Publish an invalid Task Update event which does not update the | Task_Status_Update_Missing_TaskId | | Task_Status_Update_Missing_ExecutionId | | Task_Status_Update_Missing_CorrelationId | - | Task_Status_Update_Missing_Status | @TaskUpdate Scenario Outline: Publish an valid Task Update event with a status that is invalid for current status diff --git a/tests/IntegrationTests/WorkflowExecutor.IntegrationTests/Support/DataHelper.cs b/tests/IntegrationTests/WorkflowExecutor.IntegrationTests/Support/DataHelper.cs index 8239bda1a..72d3863af 100644 --- a/tests/IntegrationTests/WorkflowExecutor.IntegrationTests/Support/DataHelper.cs +++ b/tests/IntegrationTests/WorkflowExecutor.IntegrationTests/Support/DataHelper.cs @@ -237,17 +237,14 @@ public TaskUpdateEvent GetTaskUpdateTestData(string name, string updateStatus) if (taskUpdateTestData != null && taskUpdateTestData.TaskUpdateEvent != null) { - if (!taskUpdateTestData.Name.Contains("Missing_Status")) - { - taskUpdateTestData.TaskUpdateEvent.Status = updateStatus.ToLower() switch - { - "accepted" => TaskExecutionStatus.Accepted, - "succeeded" => TaskExecutionStatus.Succeeded, - "failed" => TaskExecutionStatus.Failed, - "canceled" => TaskExecutionStatus.Canceled, - _ => throw new Exception($"updateStatus {updateStatus} is not recognised. Please check and try again."), - }; - } + taskUpdateTestData.TaskUpdateEvent.Status = updateStatus.ToLower() switch + { + "accepted" => TaskExecutionStatus.Accepted, + "succeeded" => TaskExecutionStatus.Succeeded, + "failed" => TaskExecutionStatus.Failed, + "canceled" => TaskExecutionStatus.Canceled, + _ => throw new Exception($"updateStatus {updateStatus} is not recognised. Please check and try again."), + }; TaskUpdateEvent = taskUpdateTestData.TaskUpdateEvent; diff --git a/tests/IntegrationTests/WorkflowExecutor.IntegrationTests/TestData/TaskUpdateTestData.cs b/tests/IntegrationTests/WorkflowExecutor.IntegrationTests/TestData/TaskUpdateTestData.cs index 4f4519f11..ef136acd1 100644 --- a/tests/IntegrationTests/WorkflowExecutor.IntegrationTests/TestData/TaskUpdateTestData.cs +++ b/tests/IntegrationTests/WorkflowExecutor.IntegrationTests/TestData/TaskUpdateTestData.cs @@ -228,22 +228,6 @@ public static TaskUpdateEvent CreateTaskUpdateEvent(string workflowInstanceName) } }, new TaskUpdateTestData() - { - Name = "Task_Status_Update_Missing_Status", - TaskUpdateEvent = new TaskUpdateEvent() - { - WorkflowInstanceId = Helper.GetWorkflowInstanceByName("WFI_Task_Status_Update").WorkflowInstance.Id, - ExecutionId = Helper.GetWorkflowInstanceByName("WFI_Task_Status_Update").WorkflowInstance.Tasks[0].ExecutionId, - CorrelationId = Guid.NewGuid().ToString(), - Reason = FailureReason.None, - Message = "Task Message", - TaskId = Helper.GetWorkflowInstanceByName("WFI_Task_Status_Update").WorkflowInstance.Tasks[0].TaskId, - Metadata = new Dictionary() - { - } - } - }, - new TaskUpdateTestData() { Name = "Task_Status_Update_Status_Invalid_When_Succeeded", TaskUpdateEvent = new TaskUpdateEvent()