Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleans up warnings #181

Merged

Conversation

@intere
Copy link
Collaborator

intere commented May 17, 2019

Background

  • Cleans up the compiler warnings (with one exception) in the library and the example project. The remaining warning is that we don't have a 1024x1024 app icon. ¯\_(ツ)_/¯
  • cleans up swiftlint warnings (v 0.27.0)

Breaking Changes

N/A

Meta

  • Tied to Version Release(s): next (post 1.1.0)

Checklist

  • Appropriate label has been added to this PR (i.e., Bug, Enhancement, etc.).
  • Documentation has been added to all open, and public scoped methods and properties.
  • Changelog has been updated
  • N/A Tests have have been added to all new features. (not a requirement, but helpful)
  • N/A Image/GIFs have been added for all UI related changed.
…ample project. The remaining warning is that we don't have a 1024x1024 app icon. ¯\_(ツ)_/¯
@intere intere added the enhancement label May 17, 2019
@intere intere self-assigned this May 17, 2019
@intere intere mentioned this pull request May 17, 2019
3 of 5 tasks complete
@intere intere requested a review from aaronbrethorst May 17, 2019
@intere intere marked this pull request as ready for review May 17, 2019
Copy link
Collaborator

aaronbrethorst left a comment

looks 👍

@aaronbrethorst aaronbrethorst merged commit 6496f4d into ProjectDent:develop May 17, 2019
@intere intere deleted the intere:enhancement/cleanup-warnings branch May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.