Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreates PR#158: Added ignoreAltitude in LocationNode #184

Merged
merged 4 commits into from May 25, 2019

Conversation

@intere
Copy link
Collaborator

intere commented May 17, 2019

Background

  • This feature will help when the altitude of a LocationNode is unknown
  • Allows you to add points without elevation and the elevation will just use whatever your elevation is.

Breaking Changes

N/A

Meta

  • Recreated from #158
  • Tied to Version Release(s): next (post 1.1.0)

Checklist

  • Appropriate label has been added to this PR (i.e., Bug, Enhancement, etc.).
  • Documentation has been added to all open, and public scoped methods and properties.
  • Changelog has been updated
  • Tests have have been added to all new features. (not a requirement, but helpful)
  • Image/GIFs have been added for all UI related changed.

Screenshots

@intere intere added the enhancement label May 17, 2019
@intere intere self-assigned this May 17, 2019
@intere intere requested a review from aaronbrethorst May 19, 2019
@intere intere marked this pull request as ready for review May 19, 2019
@intere intere changed the base branch from master to develop May 19, 2019
@aaronbrethorst aaronbrethorst self-assigned this May 20, 2019
Copy link
Collaborator

aaronbrethorst left a comment

looks 👍

@aaronbrethorst aaronbrethorst merged commit 7c8a838 into ProjectDent:develop May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.