Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InfoLabel includes additional heading data #203

Merged
merged 12 commits into from Jun 22, 2019
Merged

Conversation

@Pilot-Marc
Copy link
Collaborator

Pilot-Marc commented Jun 22, 2019

Background

Added line to InfoLabel to display ARKit's heading value (EulerAngles.y), and CoreLocation's heading values (CLHeading.heading and CLHeading.headingAccuracy), all displayed in degrees. This'll help diagnose heading related issues. Also, the font for the InfoLabel is now monospaced to remove the jitter
goo

Breaking Changes

N/A

Meta

  • Tied to Version Release(s):

Checklist

  • Appropriate label has been added to this PR (i.e., Bug, Enhancement, etc.).
  • Documentation has been added to all open, and public scoped methods and properties.
  • Changelog has been updated
  • Tests have have been added to all new features. (not a requirement, but helpful)
  • Image/GIFs have been added for all UI related changed.

Screenshots

Pilot-Marc and others added 12 commits Jun 18, 2019
2019 update
This eliminates an xcode compile warning
Was CLLocationDegrees, now CLLocationDirection.  Worth noting that both are doubles so the code compiled w/o error, but it's now correct.
…ly after pause/resume

Was ARWorldTracdkingConfiguration, now AROrientationTrackingConfiguration.  Heading (Euler.y) now tracks soley to AHRS, before it tried to sense and track to planes - which doesn't make sense for an outside environment.
…re-commented it. Also addressed an issue Marc found in the PR.
Adds the ability to specify World Tracking vs. Orientation Tracking
…ing.headingAccuracy to help debug heading issues

Also infoLabel uses a monospaced font to reduce jitter
@intere intere added the enhancement label Jun 22, 2019
@intere
intere approved these changes Jun 22, 2019
@intere intere merged commit f8476d9 into ProjectDent:develop Jun 22, 2019
@intere

This comment has been minimized.

Copy link
Collaborator

intere commented Jun 22, 2019

Great work @Pilot-Marc!

@Pilot-Marc Pilot-Marc mentioned this pull request Jun 22, 2019
0 of 5 tasks complete
Pilot-Marc added a commit to Pilot-Marc/ARKit-CoreLocation that referenced this pull request Jun 23, 2019
* App Store 1024x1024 Icon

This eliminates an xcode compile warning

* Fix CLHeading.headingAccuracy variable definition

Was CLLocationDegrees, now CLLocationDirection.  Worth noting that both are doubles so the code compiled w/o error, but it's now correct.

* Camera tracking mechanism sync to device orientation better, especially after pause/resume

Was ARWorldTracdkingConfiguration, now AROrientationTrackingConfiguration.  Heading (Euler.y) now tracks soley to AHRS, before it tried to sense and track to planes - which doesn't make sense for an outside environment.

* Added a configuration option for World Tracking versus Orientation Tracking.  The default is World Tracking.

* Updated the changelog.

* Added more (defaulted) parameters to the convenience initializer and re-commented it.  Also addressed an issue Marc found in the PR.

* Comments on how to use the new aRTrackingType option

* Revert "Comments on how to use the new aRTrackingType option"

This reverts commit 95d4ca0.

* InfoLabel displays ARKit.EulerAngles.y, CLHeading.heading, and CLHeading.headingAccuracy to help debug heading issues
Also infoLabel uses a monospaced font to reduce jitter
intere added a commit that referenced this pull request Jun 23, 2019
* App Store 1024x1024 Icon

This eliminates an xcode compile warning

* Fix CLHeading.headingAccuracy variable definition

Was CLLocationDegrees, now CLLocationDirection.  Worth noting that both are doubles so the code compiled w/o error, but it's now correct.

* Camera tracking mechanism sync to device orientation better, especially after pause/resume

Was ARWorldTracdkingConfiguration, now AROrientationTrackingConfiguration.  Heading (Euler.y) now tracks soley to AHRS, before it tried to sense and track to planes - which doesn't make sense for an outside environment.

* Added a configuration option for World Tracking versus Orientation Tracking.  The default is World Tracking.

* Updated the changelog.

* Added more (defaulted) parameters to the convenience initializer and re-commented it.  Also addressed an issue Marc found in the PR.

* Comments on how to use the new aRTrackingType option

* Revert "Comments on how to use the new aRTrackingType option"

This reverts commit 95d4ca0.

* Remove flicker by assigning non-conflicting z-order values to each node

* Convert TAB -> Space

* Convert TAB -> Space

* InfoLabel includes additional heading data (#203)

* App Store 1024x1024 Icon

This eliminates an xcode compile warning

* Fix CLHeading.headingAccuracy variable definition

Was CLLocationDegrees, now CLLocationDirection.  Worth noting that both are doubles so the code compiled w/o error, but it's now correct.

* Camera tracking mechanism sync to device orientation better, especially after pause/resume

Was ARWorldTracdkingConfiguration, now AROrientationTrackingConfiguration.  Heading (Euler.y) now tracks soley to AHRS, before it tried to sense and track to planes - which doesn't make sense for an outside environment.

* Added a configuration option for World Tracking versus Orientation Tracking.  The default is World Tracking.

* Updated the changelog.

* Added more (defaulted) parameters to the convenience initializer and re-commented it.  Also addressed an issue Marc found in the PR.

* Comments on how to use the new aRTrackingType option

* Revert "Comments on how to use the new aRTrackingType option"

This reverts commit 95d4ca0.

* InfoLabel displays ARKit.EulerAngles.y, CLHeading.heading, and CLHeading.headingAccuracy to help debug heading issues
Also infoLabel uses a monospaced font to reduce jitter

* Update ChangeLog for PR 203
trusk89 pushed a commit to trusk89/ARKit-CoreLocation that referenced this pull request Jul 3, 2019
* App Store 1024x1024 Icon

This eliminates an xcode compile warning

* Fix CLHeading.headingAccuracy variable definition

Was CLLocationDegrees, now CLLocationDirection.  Worth noting that both are doubles so the code compiled w/o error, but it's now correct.

* Camera tracking mechanism sync to device orientation better, especially after pause/resume

Was ARWorldTracdkingConfiguration, now AROrientationTrackingConfiguration.  Heading (Euler.y) now tracks soley to AHRS, before it tried to sense and track to planes - which doesn't make sense for an outside environment.

* Added a configuration option for World Tracking versus Orientation Tracking.  The default is World Tracking.

* Updated the changelog.

* Added more (defaulted) parameters to the convenience initializer and re-commented it.  Also addressed an issue Marc found in the PR.

* Comments on how to use the new aRTrackingType option

* Revert "Comments on how to use the new aRTrackingType option"

This reverts commit 95d4ca0.

* InfoLabel displays ARKit.EulerAngles.y, CLHeading.heading, and CLHeading.headingAccuracy to help debug heading issues
Also infoLabel uses a monospaced font to reduce jitter
trusk89 pushed a commit to trusk89/ARKit-CoreLocation that referenced this pull request Jul 3, 2019
* App Store 1024x1024 Icon

This eliminates an xcode compile warning

* Fix CLHeading.headingAccuracy variable definition

Was CLLocationDegrees, now CLLocationDirection.  Worth noting that both are doubles so the code compiled w/o error, but it's now correct.

* Camera tracking mechanism sync to device orientation better, especially after pause/resume

Was ARWorldTracdkingConfiguration, now AROrientationTrackingConfiguration.  Heading (Euler.y) now tracks soley to AHRS, before it tried to sense and track to planes - which doesn't make sense for an outside environment.

* Added a configuration option for World Tracking versus Orientation Tracking.  The default is World Tracking.

* Updated the changelog.

* Added more (defaulted) parameters to the convenience initializer and re-commented it.  Also addressed an issue Marc found in the PR.

* Comments on how to use the new aRTrackingType option

* Revert "Comments on how to use the new aRTrackingType option"

This reverts commit 95d4ca0.

* Remove flicker by assigning non-conflicting z-order values to each node

* Convert TAB -> Space

* Convert TAB -> Space

* InfoLabel includes additional heading data (ProjectDent#203)

* App Store 1024x1024 Icon

This eliminates an xcode compile warning

* Fix CLHeading.headingAccuracy variable definition

Was CLLocationDegrees, now CLLocationDirection.  Worth noting that both are doubles so the code compiled w/o error, but it's now correct.

* Camera tracking mechanism sync to device orientation better, especially after pause/resume

Was ARWorldTracdkingConfiguration, now AROrientationTrackingConfiguration.  Heading (Euler.y) now tracks soley to AHRS, before it tried to sense and track to planes - which doesn't make sense for an outside environment.

* Added a configuration option for World Tracking versus Orientation Tracking.  The default is World Tracking.

* Updated the changelog.

* Added more (defaulted) parameters to the convenience initializer and re-commented it.  Also addressed an issue Marc found in the PR.

* Comments on how to use the new aRTrackingType option

* Revert "Comments on how to use the new aRTrackingType option"

This reverts commit 95d4ca0.

* InfoLabel displays ARKit.EulerAngles.y, CLHeading.heading, and CLHeading.headingAccuracy to help debug heading issues
Also infoLabel uses a monospaced font to reduce jitter

* Update ChangeLog for PR 203
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.