Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses Issue #196 - setting the SceneLocationView delegate prevents scene rendering #206

Merged

Conversation

@intere
Copy link
Collaborator

intere commented Jun 23, 2019

Background

Issue #196 brings up a highly relevant point that when you set the delegate of the SceneLocationView, your ARCL objects don't render. To solve this, I came up with the following strategy:

  • Create a new property (that we delegate the events off to): arViewDelegate
  • If the user tries to set the delegate (to nil, or to a non-SceneLocationView object), then raise an assertionFailure
  • Demonstrate this capability in the example app

Other Changes

  • Updated swiftlint rules to only warn if files are > 500 lines and raise an error of they're > 1200 lines
  • Renamed SceneLocationView+Extensions.swift to SceneLocationView+ARSCNViewDelegate.swift
  • Ran a pod install (which changed some of the Pod resources)

Breaking Changes

There should be no breaking changes

Meta

  • Tied to Version Release(s): 1.2.1

Checklist

  • Appropriate label has been added to this PR (i.e., Bug, Enhancement, etc.).
  • Documentation has been added to all open, and public scoped methods and properties.
  • Changelog has been updated
  • Tests have have been added to all new features. (not a requirement, but helpful)
  • Image/GIFs have been added for all UI related changed.
@intere intere added the enhancement label Jun 23, 2019
@intere intere changed the title Addresses Issue #196 Addresses Issue #196 - setting the SceneLocationView delegate prevents scene rendering Jun 23, 2019
@intere intere marked this pull request as ready for review Jun 23, 2019
@intere intere requested a review from aaronbrethorst Jun 23, 2019
@aaronbrethorst aaronbrethorst self-assigned this Jun 24, 2019
Copy link
Collaborator

aaronbrethorst left a comment

lgtm 👍

@aaronbrethorst aaronbrethorst merged commit 5dd947c into ProjectDent:develop Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.