Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates polyline position/scale when GPS location is updated #209

Merged
merged 5 commits into from Jun 26, 2019

Conversation

@Pilot-Marc
Copy link
Collaborator

Pilot-Marc commented Jun 24, 2019

When GPS location (coordinates or altitude) changes, apply the same scaling logic to Polylines as we already do to Annotation nodes

This allows polylines to scale on par with annotation nodes when the location or altitude changes rapidly, such as in an automobile or elevator.

Breaking Changes

Polyline is now a subclass of LocationNode (as LocationAnnotationNode node already is). This should probably not break anything, but we should be on the lookout.

Meta

  • Tied to Version Release(s):

Checklist

  • Appropriate label has been added to this PR (i.e., Bug, Enhancement, etc.).
  • Documentation has been added to all open, and public scoped methods and properties.
  • Changelog has been updated
  • Tests have have been added to all new features. (not a requirement, but helpful)
  • Image/GIFs have been added for all UI related changed.

Screenshots

@intere intere added the enhancement label Jun 24, 2019
@intere intere self-assigned this Jun 24, 2019
@intere intere changed the title Update polyline position/scale when GPS location is updated Updates polyline position/scale when GPS location is updated Jun 25, 2019
intere and others added 2 commits Jun 25, 2019
…around Xcode's poor formatting and updated the changelog.
PR Feedback
@@ -34,9 +34,15 @@ public class PolylineNode {
self.altitude = altitude
self.boxBuilder = boxBuilder ?? Constants.defaultBuilder

super.init(location: nil)

This comment has been minimized.

Copy link
@intere

intere Jun 25, 2019

Collaborator

Can you remove the extra whitespace here?

This comment has been minimized.

Copy link
@Pilot-Marc

Pilot-Marc Jun 25, 2019

Author Collaborator

I see you beat me to it. I'll resolve conflicts, thanks!

Copy link
Collaborator

intere left a comment

one change and it should be good to go.

@intere

This comment has been minimized.

Copy link
Collaborator

intere commented Jun 25, 2019

Also - there are merge conflicts that need to be resolved. Let me know if you need help with it.

intere and others added 2 commits Jun 25, 2019
Addresses merge conflicts
@intere

This comment has been minimized.

Copy link
Collaborator

intere commented Jun 26, 2019

Don't worry about the broken CI - I'll be fixing that.

@intere
intere approved these changes Jun 26, 2019
Copy link
Collaborator

intere left a comment

Thanks for being patient! Nice work @Pilot-Marc

@intere intere merged commit 72c4927 into ProjectDent:develop Jun 26, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
trusk89 pushed a commit to trusk89/ARKit-CoreLocation that referenced this pull request Jul 3, 2019
…Dent#209)

* Update polyline position/scale when GPS location is updated

* Addressed swiftlint issues, reformatted the code in a way that works around Xcode's poor formatting and updated the changelog.
@Pilot-Marc Pilot-Marc deleted the Pilot-Marc:Update-Polyline-Position branch Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.