Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Just sending in an early pull request for search within. I think it should definitely still be considered a work in progress. But I think its worth getting wider feed back and design review before we take in much further.
(Don't be misled by branch name. By 2.1 we simply meant search within work built on top of 2.1 release branch)
… contents ranges that don't include all canvas; i.e. fixes bug seen in Gracilis manuscript display
…linking to change canvas to target of search results. Functions have been embedded into window.js as part of $.Window object, but probably need to be moved to a child object
… conform to more closely to mirador organization; main functionality continues to be working
…t and to modify annotation list to show highlighting of search results
… array or object as value of service field. function now check context to see if this is the service for searching
…anifest is open in the workspace
…arch within form added to window template
…rrent page; I also turned on annotations; not lots of jsonblob errors at present, I'm not sure where that is coming from
…Os added in comments
…dispalys search block label in search service drop down menu
…s to associated page as expected. Removed various console logs.
Just to note: users will in some cases arrive at the viewer after executing a full-text search in a discovery environment; it will be useful to be able to pass search terms from that environment to Mirador so that the search is executed when the manifest is opened ... so, there should be an initialisation parameter that can be assigned search terms.
Is this PR still under active development? It would be great to get search API integration into upcoming versions of Mirador, and we at University of Toronto are interested in integrating your additions. If you are ready but the test coverage drop is preventing it from being accepted, please let me know if I can help out with that.
I think we're more or less waiting for a design review and discussion of the best ways to use the side panel. The search panel works as is, but it's just a matter of what its final integration should look like. I think it is definitely a priority for 2.2
@jbaiter - @jeffreycwitt and others submitted this PR as a WIP as a way to stimulate discussion and feedback on how to implement Search Within in Mirador. And indeed what has followed has been a detailed discussion and design process to specify the implementation. The current proposal, I believe, is for a small group of engineers to work on this in early 2017. It remains a high priority, just waiting for an engineering team to mobilize at the right moment to re-implement according to the new specification. https://docs.google.com/document/d/1uvwgAvPGxhM94wYylMItSV6nd39V9uObd82NrjoDI9Y/edit?usp=sharing