New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins info in readme and tutorial; questions header in readme #108

Merged
merged 6 commits into from Jul 14, 2017

Conversation

Projects
None yet
3 participants
@idk3
Collaborator

idk3 commented Jul 14, 2017

No description provided.

@babbush

See comments, also, please add @damiansteiger and @jarrodmcc as reviewers as they should both approve.

README.rst Outdated
Questions?
----------
Contact fermilib at projectq.ch.

This comment has been minimized.

@babbush

babbush Jul 14, 2017

Contributor

I would write: "Contact the FermiLib team by emailing us at fermilib@projectq.ch"

So actually include the link. These days, bots are smart enough to look for " at " and identify it as an email. I'm not that worried.

README.rst Outdated
Plugins
-------
In order to generate molecular hamiltonians in Gaussian basis sets and perform other complicated electronic structure calculations, one can install plugins. We currently support PySCF and Psi4, plugins for which can be found `here <http://projectq.ch/code-and-docs/#Fermilib>`__.

This comment has been minimized.

@babbush

babbush Jul 14, 2017

Contributor

No, please link directly to the git repos for Psi4 and pyscf plugins.

@babbush babbush requested review from jarrodmcc and damiansteiger Jul 14, 2017

README.rst Outdated
Questions?
----------
If you have any other questions, please contact fermilib at projectq.ch.

This comment has been minimized.

@damiansteiger

damiansteiger Jul 14, 2017

Member

Could you display the full email address as fermilib@projectq.ch?
Makes it simple to copy & paste (from our previous experience it does not lead to more spam)

This comment has been minimized.

@babbush

babbush Jul 14, 2017

Contributor

Yeah I made the same comment but somebody cough @idk3 cough was worried that bots would find the email address and spam us. But I don't think it is too common to crawl GitHub for this sort of thing. Ian, please change (or contest) and then write something so I know you made the change. I will then merge the PR.

This comment has been minimized.

@idk3

idk3 Jul 14, 2017

Collaborator

loooool ok, I've changed it

@idk3 idk3 dismissed stale reviews from damiansteiger and babbush via 60ad605 Jul 14, 2017

@babbush babbush merged commit b5eed09 into ProjectQ-Framework:develop Jul 14, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 97.393%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment