New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/ph gate #151

Merged
merged 2 commits into from Oct 1, 2017

Conversation

Projects
None yet
2 participants
@damiansteiger
Member

damiansteiger commented Sep 30, 2017

Fixes a previously missed bug that Ph gates need to be applied to single qubits.

damiansteiger added some commits Sep 30, 2017

@damiansteiger

This comment has been minimized.

Member

damiansteiger commented Sep 30, 2017

This should also fix errors which appeared in forks such as
quantumlib/OpenFermion-ProjectQ#11
quantumlib/OpenFermion-ProjectQ#14

@babbush

babbush approved these changes Oct 1, 2017

@babbush babbush merged commit 90a194c into develop Oct 1, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0003%) to 99.42%
Details
@babbush

This comment has been minimized.

Contributor

babbush commented Oct 1, 2017

👍 it is perhaps time to tag a new version of FermiLib and pull to master. Don't you think?

@damiansteiger damiansteiger deleted the bugfix/ph_gate branch Oct 1, 2017

@damiansteiger

This comment has been minimized.

Member

damiansteiger commented Oct 1, 2017

Sure, I will prepare a new release.

@damiansteiger damiansteiger restored the bugfix/ph_gate branch May 4, 2018

gaming-hacker added a commit to gaming-hacker/FermiLib that referenced this pull request May 23, 2018

Merge commit '9aef7d5a912ebe759a2877c8aea5754a4db93543' into v1
* commit '9aef7d5a912ebe759a2877c8aea5754a4db93543': (25 commits)
  arXiv reference (ProjectQ-Framework#158)
  Add citation (ProjectQ-Framework#153)
  Added link to OpenFermion, as discussed (ProjectQ-Framework#152)
  Bugfix/ph gate (ProjectQ-Framework#151)
  Opt (ProjectQ-Framework#149)
  Updated headers (ProjectQ-Framework#150)
  Dual basis expectation with plane-wave state (ProjectQ-Framework#148)
  Handled IOError in MolecularData.get_from_file() function (ProjectQ-Framework#145)
  Hard seeds for tests using random module (ProjectQ-Framework#147)
  Docker in readme (ProjectQ-Framework#144)
  Fix of sly bug in low-depth simulation with onsite interaction (ProjectQ-Framework#143)
  Removing lingering references to orbital overlaps (ProjectQ-Framework#142)
  Removed unnecessary docs from BKSF code. (ProjectQ-Framework#141)
  Cleaned up some unnecessary docs (ProjectQ-Framework#140)
  Bksf (ProjectQ-Framework#123)
  Remove orbital overlaps from molecular data (ProjectQ-Framework#139)
  Fixing demo notebook (ProjectQ-Framework#138)
  FFFT, low depth dual basis Trotter simulation code (in circuits) (ProjectQ-Framework#136)
  Improve speed of Travis
  Breaking utils into utils and circuits (ProjectQ-Framework#135)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment