dalgo migration : Incorrect Request Type in start_thread Endpoint #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nishika26
changed the title
nishika26
requested review from
AkhileshNegi and
jerome-white
and removed request for
jerome-white
jerome-white
approved these changes
May 14, 2025
AkhileshNegi
approved these changes
May 15, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where the request parameter in the start_thread endpoint was incorrectly typed as OpenAIThreadCreate. The request should not be of type OpenAIThreadCreate, but rather a general dict type, as it only represents the data sent in the body of the request and not the entity being saved to the database