Skip to content

libpiano incompatible #157

Closed
timnovinger opened this Issue Sep 22, 2011 · 10 comments

5 participants

@timnovinger

It looks like Pandora's latest round of site updates has broken Pianobar / libpiano.

@durka
durka commented Sep 22, 2011

I can confirm this.

Welcome to pianobar (2011.07.09-dev)! Press ? for a list of commands.
(i) Login... Error: Protocol incompatible. Please upgrade libpiano.

@ZigZagJoe

Keys have not changed, looking for changes in protocol now. Does work with simply incrementing the version.

@durka
durka commented Sep 22, 2011

WFM also with simply incrementing the protocol version on line 45 in piano.c to "32". I didn't try anything besides log in -> select station -> start playing a song.

@timnovinger

I can confirm @durka's comment, that fix worked for me as well. Is that a submittable patch, or is there a better fix for this issue?

@timnovinger

Just noticed a good side effect of incrementing the protocol version...bookmarking songs/artists now functions again. It's been producing errors for a decent while now.

@computerquip

Just a suggestion, why not add a basic configuration file or a command switch to force the protocol version in the case this happens again?

@PromyLOPh
Owner

I’m working on it. There are a few api changes that I have to catch up with.

@computerquip: This doesn’t make sense. There’s a reason for api versioning.
@timnovinger: And you didn’t file a bug report?

@PromyLOPh
Owner

See 349bb98 or release 2011.09.22.

@PromyLOPh PromyLOPh closed this Sep 22, 2011
@timnovinger

@PromyLOPh, sorry I meant to but kept forgetting to file one.

@PromyLOPh
Owner

I think I fixed this a while ago anyway...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.