Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fixed building when LDFLAGS contains -Wl,--as-needed #259

Closed
wants to merge 1 commit into from

2 participants

@belak

This fixes #258
Simply makes sure we link against json-c and gnutls when linking pianobar (when using DYNLINK=1)

Simply because libpiano doesn't use all the symbols linked to in pianobar, so when using --as-needed, not all symbols are resolved and stuff not used in libpiano can't be found when linking for pianobar.

@PromyLOPh
Owner
@PromyLOPh PromyLOPh closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on May 16, 2012
  1. @belak
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  Makefile
View
2  Makefile
@@ -91,7 +91,7 @@ ifeq (${DYNLINK},1)
pianobar: ${PIANOBAR_OBJ} ${PIANOBAR_HDR} libpiano.so.0
@echo " LINK $@"
@${CC} -o $@ ${PIANOBAR_OBJ} ${LDFLAGS} -lao -lpthread -lm -L. -lpiano \
- ${LIBFAAD_LDFLAGS} ${LIBMAD_LDFLAGS} ${LIBGNUTLS_LDFLAGS}
+ ${LIBFAAD_LDFLAGS} ${LIBMAD_LDFLAGS} ${LIBGNUTLS_LDFLAGS} ${LIBJSONC_LDFLAGS} ${LIBGCRYPT_LDFLAGS}
else
pianobar: ${PIANOBAR_OBJ} ${PIANOBAR_HDR} ${LIBPIANO_OBJ} ${LIBWAITRESS_OBJ} \
${LIBWAITRESS_HDR}
Something went wrong with that request. Please try again.