Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Ubuntu 12.04 instructions. #281

Closed
wants to merge 1 commit into from
Closed

Adding Ubuntu 12.04 instructions. #281

wants to merge 1 commit into from

Conversation

jc00ke
Copy link
Contributor

@jc00ke jc00ke commented Jun 29, 2012

Closes #278

@PromyLOPh
Copy link
Owner

Thanks for the pull request. Although I rejected a similar pull request
in the past (#249) I feel there’s demand for this kind of information.
So, I see a few options how to proceed now:

  1. Apply as is. Con: Document is going to get very
    long/confusing as we add more distributions
  2. Every distribution into a single file (INSTALL.debian,
    INSTALL.ubuntu, …). Con: A lot of files in the root directory
  3. Reject the pull request.
  4. Enable the github wiki and put it there. Con: Fragmentation of
    information, pro: everyone can edit
  5. Actually solve the problem by providing up-to-date packages for every
    Linux distribution, so noone has to build the latest pianobar from
    source. Con: A lot of work, pro: Package manager/packager handles all
    the ugly bits (dependencies, updates, …)

At the moment 2) is my favorite. What do you think? :)

@jc00ke
Copy link
Contributor Author

jc00ke commented Jul 1, 2012

I would vote for option 1. As long as we keep the INSTALL file in alphabetical order for operating systems, it shouldn't get too bad.

If option 2 were to be taken, I would suggest creating a install/ directory so the root directory isn't muddied. INSTALL could just say Find OS-specific instructions in the install/ directory

But yeah, +1 for option 1 ;)

PromyLOPh pushed a commit that referenced this pull request Jul 2, 2012
@PromyLOPh
Copy link
Owner

Applied with minor modifications (tabs not spaces, removed git clone –
we assume you already have a checkout/tarball/whatever if you’re reading
INSTALL). We’ll see how well this works – thanks :)

@PabloTwo
Copy link

PabloTwo commented Jul 2, 2012

There seems to be no requirement for libfaac-dev to build pianobar in Ubuntu >=12.04, or any other Linux distribution. libfaac is an encoder, libfaad is the decoder. I am a Fedora user and not an Ubuntu user. Of course, installing libfaac-dev does no harm, but, in my opinion, should not be listed as a build requirement when it is not.

@jc00ke
Copy link
Contributor Author

jc00ke commented Jul 2, 2012

I can confirm that libfaac-dev isn't needed on Ubuntu. Sorry for not checking first!

@PromyLOPh
Copy link
Owner

What about gcrypt? It isn’t listed in the apt-get command.

@jc00ke
Copy link
Contributor Author

jc00ke commented Jul 2, 2012

@PromyLOPh I don't have gcrypt installed & I'm listening to pianobar as I type ;)

PromyLOPh pushed a commit that referenced this pull request Jul 3, 2012
@PromyLOPh
Copy link
Owner

I merged your fixes.

@PromyLOPh PromyLOPh closed this Jul 3, 2012
@PabloTwo
Copy link

PabloTwo commented Jul 3, 2012

@jc00ke - Clearly, libgcrypt-dev (assuming that's the correct file name in Ubuntu) should be in the build requirements list. Although pianobar may compile without complaining without libgcrypt-dev installed, doing so disables the ability to use that function. I build pianobar into rpm packages (32 and 64 bit) for Fedora users, including libgcrypt-devel (Fedoras name). Using the rpm command to query the built pianobar rpm package what its "requirements" are when the gcrypt header files are present during the build, included among the list are, for 64 bit::

libgcrypt.so.11()(64bit)
libgcrypt.so.11(GCRYPT_1.2)(64bit)

A user installing my rpm package would have the libgcrypt rpm package pulled in as a dependency if it were not already installed on his system. Maybe too late to add this comment after being "Closed" ?

@jc00ke
Copy link
Contributor Author

jc00ke commented Jul 3, 2012

@PabloTwo libgcrypt11-dev must have already been installed on my system. Oops.

@PromyLOPh
Copy link
Owner

So we have to add libgcrypt11-dev to the apt-get too?

@PabloTwo
Copy link

PabloTwo commented Jul 4, 2012

Yes, libgcrypt11-dev should be included in the list of packages to install in the Ubuntu specific instructions.

And thanks for a great program (pianobar) and all your efforts at keeping up with the API changes.

@PromyLOPh
Copy link
Owner

Fixed.

PromyLOPh added a commit that referenced this pull request Jul 7, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while executing make clean && make Ubuntu
3 participants