New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Ubuntu 12.04 instructions. #281
Conversation
Thanks for the pull request. Although I rejected a similar pull request
At the moment 2) is my favorite. What do you think? :) |
I would vote for option 1. As long as we keep the If option 2 were to be taken, I would suggest creating a But yeah, +1 for option 1 ;) |
Applied with minor modifications (tabs not spaces, removed git clone – |
There seems to be no requirement for libfaac-dev to build pianobar in Ubuntu >=12.04, or any other Linux distribution. libfaac is an encoder, libfaad is the decoder. I am a Fedora user and not an Ubuntu user. Of course, installing libfaac-dev does no harm, but, in my opinion, should not be listed as a build requirement when it is not. |
I can confirm that |
What about gcrypt? It isn’t listed in the apt-get command. |
@PromyLOPh I don't have |
I merged your fixes. |
@jc00ke - Clearly, libgcrypt-dev (assuming that's the correct file name in Ubuntu) should be in the build requirements list. Although pianobar may compile without complaining without libgcrypt-dev installed, doing so disables the ability to use that function. I build pianobar into rpm packages (32 and 64 bit) for Fedora users, including libgcrypt-devel (Fedoras name). Using the rpm command to query the built pianobar rpm package what its "requirements" are when the gcrypt header files are present during the build, included among the list are, for 64 bit:: libgcrypt.so.11()(64bit) A user installing my rpm package would have the libgcrypt rpm package pulled in as a dependency if it were not already installed on his system. Maybe too late to add this comment after being "Closed" ? |
@PabloTwo |
So we have to add libgcrypt11-dev to the apt-get too? |
Yes, libgcrypt11-dev should be included in the list of packages to install in the Ubuntu specific instructions. And thanks for a great program (pianobar) and all your efforts at keeping up with the API changes. |
Fixed. |
Closes #278