Fix "Network error: TLS read failed." #336

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants

@pvstodghill's patch in issue #321 (https://github.com/PromyLOPh/pianobar/issues/321#issuecomment-10408772) fixes "Network error: TLS read failed." at login, at least on my Linux system, and was verified for Mac OS X in the issue thread as well.

All I have done is committed the patch.

@prattmic prattmic Apply @pvstodghill's patch from Issue #321
Fixes TLS read errors when attempting to get high quality audio.
1bbb2a7
Owner

PromyLOPh commented Dec 30, 2012

  1. I’m the author of the initial patch.
  2. There’s a reason I have not commited it yet, see
    https://github.com/PromyLOPh/pianobar/issues/321#issuecomment-10256848
    (tl;dr: I blame Pandora.)

@PromyLOPh I'm not sure I understand your reason for not committing it. Sounds like Pandora you're saying Pandora is violating the TLS spec. But it doesn't seem like there is anything Pianobar can do about that, other than ignore it, which AFAICT is what your patch (or the updated version here) does.

Ignoring the spec violation does have the virtue of making Pianobar work with hifi audio.

Owner

PromyLOPh commented Feb 14, 2013

Yeah, it’s basically a question how much “bug-compatibility” we can/want
to accept.

If Pandora was sending broken HTTP or something like that: Fine, we can
code around that. But TLS and crypto stuff in general is a different
thing imo. If you don’t know exactly what you’re doing you shouldn’t
mess with it. I’m not an expert and have to rely on the expert’s
judgement (libraries return codes in this case). And they say it’s an
error.

On the other hand working hifi support is desireable of course.

I just wanted to note that I as of last week I was getting the TLS read error again. I just merged @prattmic 's master branch, rebuilt, and pianobar is working again for me.
I'm on osx 10.8.3 using high audio quality setting.

Thank you @prattmic

Owner

PromyLOPh commented May 19, 2013

See commit ea4324b

PromyLOPh closed this May 19, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment