Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Automatic setting of CC on OS X #340

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

tchajed commented Jan 5, 2013

Avoids the need to set CC manually on OS X. This takes care of issue #308 without a workaround.

@tchajed tchajed using gcc -std=c99 instead of c99 on OS X
automatic checking in Makefile
52c3647
Owner

PromyLOPh commented Jan 6, 2013

So the section in INSTALL about OS X (overriding CFLAGS) is actually
obsolete/does not work with CC=c99 and should be removed?

Contributor

tchajed commented Jan 6, 2013

Yes, since Lion (the oldest official supported release due to Apple's policies) it's no longer true that c99 generates 32-bit binaries by default on OS X. Modifying CFLAGS doesn't fix the actual issue on OS X, which is that c99 doesn't support the -M option to generate dependency files, while gcc does. This doesn't actually hinder building (the dependencies are not necessary for a first-time build), but it's not good for development since incremental recompilation can be incorrect and make generates unnecessary "unsupported option -- M" messages.

You can probably leave that note in the INSTALL, with the caveat that it's for Snow Leopard (I can't test that out, though).

@PromyLOPh PromyLOPh added a commit that referenced this pull request Jan 9, 2013

@tchajed @PromyLOPh tchajed + PromyLOPh Use gcc -std=c99 instead of c99 on OS X
Automatic checking in Makefile. Fixes #308 and #340.
4ebcb14

@PromyLOPh PromyLOPh added a commit that referenced this pull request Jan 9, 2013

@PromyLOPh PromyLOPh Remove install note about OS X
Should work “out of the box” now. See #340.
efd4f39
Owner

PromyLOPh commented Jan 9, 2013

I commited your changes and removed the section in INSTALL. Thanks for
the patch!

@PromyLOPh PromyLOPh closed this Jan 9, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment