Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add varint unit tests #53

Closed
wants to merge 1 commit into from

Conversation

@deathcap
Copy link

commented Feb 20, 2016

Adds some varint unit tests extracted from #51

This leaves the >32-bit overflow behavior (tests commented-out for now)

@rom1504 rom1504 referenced this pull request Feb 26, 2016
22 of 22 tasks complete
rom1504 added a commit that referenced this pull request Feb 28, 2016
@rom1504

This comment has been minimized.

Copy link
Member

commented Feb 28, 2016

I added all the passing tests in 29c0412

I'll let you add the rest of them ;)

@roblabla

This comment has been minimized.

Copy link
Collaborator

commented Feb 28, 2016

Please use it.skip instead of commenting out.

@rom1504

This comment has been minimized.

Copy link
Member

commented Mar 1, 2016

Might need to add 2 things to my test schema for this:

  • a skip property
  • a "should fail" property
@rom1504

This comment has been minimized.

Copy link
Member

commented Aug 24, 2019

seems like we haven't needed this
if someone need this one day, he can reopen

@rom1504 rom1504 closed this Aug 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.