Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readArray at datatypes/structures.js #98

Open
wants to merge 2 commits into
base: master
from

Conversation

@Saiv46
Copy link

commented Sep 1, 2019

Using Array.push and accessing the object's result.value property is performance-cost by itself.

Maybe we should improve that?

  • Benchmark it
  • Merge
Saiv46 added 2 commits Sep 1, 2019
Using Array.push and accessing the object's `result.value` property is performance-cost by itself.

Maybe we should improve that?

[] Test it won't break anything
[] Benchmark it
[] Merge
@rom1504

This comment has been minimized.

Copy link
Member

commented Sep 1, 2019

@Saiv46

This comment has been minimized.

Copy link
Author

commented Sep 2, 2019

If you're serious in your efforts to optimize protodef, the way to go is to produce a protocol json to JavaScript compiler. (The code is currently an interpreter).
It would be a fun project but will also take some time.

There's already performant code generators such as astring, I think I can somehow convert json protocol to AST in the future "compiler".

@rom1504

This comment has been minimized.

Copy link
Member

commented Sep 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.