New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Glowstone version to latest to support 1.12.2. #717

Merged
merged 1 commit into from Oct 16, 2017

Conversation

Projects
None yet
2 participants
@momothereal
Contributor

momothereal commented Oct 16, 2017

Updated Glowstone from 2017.9.0 (1.12.1) to 2017.10.0 (1.12.2).

Looks like if you use a library for an older version, the compiler will 'cache' the server version (here: GlowServer.GAME_VERSION) instead of getting the actual version from the server. This means that using the latest ProtocolSupport with the latest Glowstone build will shutdown the server because the plugin thinks the version is 1.12.1 even though the server is on 1.12.2.

I don't know about gradle, but in Maven I think the <scope>runtime</scope> dependency tag would prevent this. Or maybe reflection would be more appropriate here.

@Shevchik Shevchik merged commit 9350718 into ProtocolSupport:master Oct 16, 2017

@momothereal momothereal deleted the momothereal:glowstone-1.12.2 branch Oct 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment