From c71654d8d036ada18ba73e72609ebf2587979093 Mon Sep 17 00:00:00 2001 From: Michael Dailey Date: Tue, 2 Jun 2026 17:26:40 -0500 Subject: [PATCH] PDX-0: chore(docs): use portable, non-personal paths in test and loop docs RCA: Copilot review on PR #201 flagged a hard-coded personal Windows username (mrdai) in an sfSpawn test path and two loop-doc example paths; personal/environment-specific paths are non-portable and embed identifying detail. Fix: Replace mrdai with the generic "username" in the win32 sfSpawn test (still a spaced Windows path, preserving the space-handling assertion) and switch the loop-doc example paths to OS- and user-agnostic ~/git/... form. --- docs/loops/pdx-501-505.md | 4 ++-- test/unit/mcp/sfSpawn.test.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/loops/pdx-501-505.md b/docs/loops/pdx-501-505.md index d12aabf..a5827ea 100644 --- a/docs/loops/pdx-501-505.md +++ b/docs/loops/pdx-501-505.md @@ -82,12 +82,12 @@ TICKET-SPECIFIC RULES: authored testcases: • AssertValues / assertValuesComparison (apiId com.provar.plugins.bundled.apis.AssertValues) — valid set from - C:\Users\mrdai\git\provar-manager-regression\tests\ComparisonTypes.testcase: + ~/git/provar-manager-regression/tests/ComparisonTypes.testcase: EqualTo, NotEqualTo, GreaterThan, GreaterThanOrEqualTo, LessThan, LessThanOrEqualTo, IsPresent, IsEmpty, Matches, NotMatches, Contains, NotContains, StartsWith, NotStartsWith, EndsWith, NotEndsWith (16) • UiAssert / uiAttributeAssertion — valid set from the comparisonType - attributes in C:\Users\mrdai\git\provar-manager-regression\tests\SauceDemo Purchase Flow (Demo).testcase: + attributes in ~/git/provar-manager-regression/tests/SauceDemo Purchase Flow (Demo).testcase: EqualTo, Contains, StartsWith, EndsWith, Matches, None (6) (dropdown labels: Equals→EqualTo, Contains, Starts With→StartsWith, Ends With→EndsWith, Matches; Ignore/Read→None. Verify the Ignore-vs-Read diff --git a/test/unit/mcp/sfSpawn.test.ts b/test/unit/mcp/sfSpawn.test.ts index b41e085..34bcc9c 100644 --- a/test/unit/mcp/sfSpawn.test.ts +++ b/test/unit/mcp/sfSpawn.test.ts @@ -384,7 +384,7 @@ describe('runSfCommand', () => { it('(c) does not split an argument value containing a space', () => { setSfPathCacheForTesting('sf'); - const propsPath = 'C:\\Users\\mrdai\\git\\Provar Manager\\test-manager\\provardx-properties.json'; + const propsPath = 'C:\\Users\\username\\git\\Provar Manager\\test-manager\\provardx-properties.json'; runSfCommand(['provar', 'automation', 'config-load', '--properties-file', propsPath]); const [exe, args] = spawnStub.firstCall.args as [string, string[]]; assert.equal(exe, 'sf'); // space-free executable stays unquoted