New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Handoff support for server #478

Merged
merged 2 commits into from Dec 17, 2016

Conversation

Projects
None yet
3 participants
@gklka
Contributor

gklka commented Dec 12, 2016

When the user starts the internal web server, it's address will be announced via Handoff, so he or she can easily click on the Safari icon on the Mac to open it instead of typing the IP address manually.

@jasarien

This comment has been minimized.

Collaborator

jasarien commented Dec 12, 2016

That's pretty cool - never thought of that.

@jasarien

This comment has been minimized.

Collaborator

jasarien commented Dec 12, 2016

Can you revert the changes to the bundle IDs and code signing? I'll test it in the mean time.

@gklka

This comment has been minimized.

Contributor

gklka commented Dec 12, 2016

I'll try to do it next morning. (I am new to pull requests, sorry.)

@jasarien

This comment has been minimized.

Collaborator

jasarien commented Dec 12, 2016

Tested it out, works well. Thanks! 👍

Just clean up the bundle IDs and codesigning identities to what they were and I can merge this.

@gklka

This comment has been minimized.

Contributor

gklka commented Dec 13, 2016

Did it!

@apexad

This comment has been minimized.

Contributor

apexad commented Dec 14, 2016

Does this work with AppleTV too? Might be a fix for #446? Assuming this issue was due to a mis-typed URL for the import web server.

@jasarien

This comment has been minimized.

Collaborator

jasarien commented Dec 14, 2016

Try it

@gklka

This comment has been minimized.

Contributor

gklka commented Dec 14, 2016

I'll test it tonight

@gklka

This comment has been minimized.

Contributor

gklka commented Dec 15, 2016

Unfortunately it does not work with Apple TV. I am not sure if it is a bug or the Apple TV does not support it. (Documentation says it should.)

@gklka

This comment has been minimized.

Contributor

gklka commented Dec 15, 2016

I've made a research, and despite the documentation states that NSUserActivity is supported on tvOS, but according to forums, it is not working at all. All I can do is to leave the currently not working code in the project, and wait until Apple finishes the work.

@jasarien jasarien merged commit 14b0e77 into Provenance-Emu:master Dec 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment