feat: corruption loadout import/export #114
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I looked at the suggestion in the issue and I'm a bit concerned about spacing. When you add all the cube types to the ascend history, there isn't much room for buttons on the right:
|
|
Oh, I didn't think of it. I might just make the whole corruption cell clickable instead, with a tooltip at the bottom. Thanks! |
KhafraDev
requested changes
Aug 9, 2021
| @@ -201,10 +201,15 @@ export const corruptionLoadoutTableCreate = () => { | |||
| } | |||
| if (i === 0) { | |||
| let cell = row.insertCell(); | |||
| //empty | |||
| let btn = document.createElement("button"); | |||
| let btn = document.createElement("button"); | ||
| btn.className = "corrSave" | ||
| btn.textContent = "Import" | ||
| btn.onclick = () => corruptionLoadoutImportPrompt(); |
|
|
||
| cell = row.insertCell(); | ||
| let btn = document.createElement("button"); | ||
| btn = document.createElement("button"); |
Comment on lines
+263
to
+266
| [ | ||
| 'Please enter comma-separated corruption values. Current loadout:', | ||
| player.prototypeCorruptions.join(','), | ||
| ].join('\n') |
| return Alert('Invalid format! Corruption loadouts should be 13 comma-separated numbers.'); | ||
| } | ||
|
|
||
| player.prototypeCorruptions = importLoadout; |
There was a problem hiding this comment.
what if one of these is NaN, negative, infinite, etc?
|
|
||
| cell = row.insertCell(); | ||
| let btn = document.createElement("button"); | ||
| btn = document.createElement("button"); | ||
| btn.className = "corrLoad" | ||
| btn.textContent = "Zero" | ||
| btn.onclick = () => corruptionLoadoutSaveLoad(false, i); |
There was a problem hiding this comment.
please addEventListener here too
| player.prototypeCorruptions = importLoadout; | ||
| corruptionLoadoutTableUpdate(); | ||
| corruptionStatsUpdate(); | ||
| }; |
|
|
||
| export const copyToClipboard = async (text: string) => { | ||
| if ('clipboard' in navigator) { | ||
| await navigator.clipboard.writeText(text) |
There was a problem hiding this comment.
return void navigator.clipboard...
| await navigator.clipboard.writeText(text) | ||
| .catch(e => console.error(e)); | ||
|
|
||
| return; |
| @@ -102,3 +102,27 @@ export const btoa = (s: string) => { | |||
| return null; | |||
| } | |||
| } | |||
|
|
|||
| export const copyToClipboard = async (text: string) => { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor refactor: move "Copy to clipboard" save export feature to a new
copyToClipboardfunctionFixes #113