Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing usage option(s)! #30

Open
OZTaekOppa opened this issue Jan 3, 2024 · 4 comments
Open

Missing usage option(s)! #30

OZTaekOppa opened this issue Jan 3, 2024 · 4 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@OZTaekOppa
Copy link

Thank you for the excellent program. I am currently testing the latest version with several parameters for ONT ultra-long read datasets. However, I noticed a potential omission in usage options and explanations, specifically "--trim_strategy dna." Just to ensure there are no other missing usages, could you please review and address any oversights?

@Psy-Fer
Copy link
Owner

Psy-Fer commented Jan 3, 2024

Hello.

There isn't a --trim_strategy in the python library API, so I think you can parse it along to guppy/dorado.

Any argument, like --use_tcp that isn't in the buttery-eel cli is parsed through to guppy/dorado callers and tried there. If they don't exist there, then there will probably be an error.

I don't know if you have looked at the guppy/dorado CLI, but it's a massive mess.

Anyway, what does the trim_strategy do exactly and how would you use it?

Cheers,
James

@OZTaekOppa
Copy link
Author

Hi James,

After discussing with Hasindu and Jill, she mentioned that "in the past, to remove adapters I've used these settings during re-basecalling; --detect_mid_strand_adapter --trim_adapters --detect_adapter --do_read_splitting --trim_strategy dna."

From the buttery-eel -h, I couldn't precisely discern what it meant. However, it seems to pertain to trimming adapter sequences in a DNA sequence. I am currently testing these parameters "--detect_mid_strand_adapter --trim_adapters --detect_adapter --do_read_splitting --trim_strategy dna" with the latest ONT Ultra-Long datasets (NCIG).

So far, the program is running without any issues on gadi.
I am also testing without the option of --trim_strategy dna.

Can you confirm that the latest buttery-eel version has no missing usages/explanations?

Cheers,

Taek

@Psy-Fer
Copy link
Owner

Psy-Fer commented Jan 3, 2024

Hey Taek,

Yea there are things missing, but that is either because they are not in the library API (supplied by ONT), or are not supported (like alignment while basecalling). Refer to the guppy_basecaller --help for all possible options.

On this note, I should add some more explanations about some of the "common" arguments that are parsed through to guppy/dorado and not in the buttery-eel CLI. Things like --use_tcp for instance.

It would be good to know the outcome of the trim_strategy on/off differences. What are the other options other than dna ? I imagine there is a default value?

Cheers,
James

@Psy-Fer
Copy link
Owner

Psy-Fer commented Aug 16, 2024

TODO: Add "common" arguments and some command recipes to the docs to help people get going quicker without entering documentation hell.

@Psy-Fer Psy-Fer self-assigned this Aug 16, 2024
@Psy-Fer Psy-Fer added the documentation Improvements or additions to documentation label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants