Skip to content

Commit

Permalink
Committing cran comments for release
Browse files Browse the repository at this point in the history
  • Loading branch information
PHEgeorginaanderson committed Jan 13, 2020
1 parent 9265a24 commit e9e7c8e
Showing 1 changed file with 8 additions and 11 deletions.
19 changes: 8 additions & 11 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,21 +1,18 @@

## Submission of updated package version 1.2.0
This package contains a bug fix for the phe_quantile function that results in backwards-incompatibility due to an argument being deprecated (will show as error if used for time being). Also minor edits to utilise the rlang {{}} embrace notation, remove phe_sii warnings on tests and minor enhancements to functionality.



## Submission of package version 1.2.0
This package contains a bug fix for the phe_quantile function that results in backwards-incompatibility due to an argument being deprecated (helpful error will be generated if deprecated argument used for time being). Also minor edits to utilise the rlang {{}} embrace notation, remove phe_sii warnings on tests and minor enhancements to functionality.

## R CMD check results
There were no ERRORs, WARNINGS or NOTES on local Windows 10 install using R 3.6.1 and RStudio 1.2.1335.
There were no ERRORs, WARNINGS or NOTES on local Windows 10 install using R 3.6.2 and RStudio 1.2.5019

## Test Environments
* local windows 10 installs: R3.6.1 - OK
* local windows 10 installs: R3.6.2 - OK

* Travis check on Linux (2019-09-03) - passed
* Travis check on Linux (2020-01-13) - passed

* devtools::check_win gave no ERRORS, WARNINGS or NOTES on the following versions: R version 3.5.3 (2019-03-11), R version 3.6.1 (2019-07-05) and R Under development (unstable) (2019-09-02 r77130).
* devtools::check_win gave no ERRORS, WARNINGS or NOTES on the following versions: R version 3.5.3 (2019-03-11), R version 3.6.2 (2019-12-12) and R Under development (unstable) (2020-01-07 r77633).

* devtools::check_rhub has been run on the following platforms: Debian Linux, R-devel, clang, ISO-8859-15 locale; Fedora Linux, R-devel, clang, gfortran; Windows Server 2008 R2 SP1, R-devel, 32/64 bit; Ubuntu Linux 16.04 LTS, R-release, GCC. These build checks produced a couple of NOTES about possible mispellings, possible invalid DOIs which are all valid and not critical to the functioning of the package.
* devtools::check_rhub has been run on the following platforms: Fedora Linux, R-devel, clang, gfortran; Windows Server 2008 R2 SP1, R-devel, 32/64 bit; Ubuntu Linux 16.04 LTS, R-release, GCC. These build checks produced a couple of NOTES about possible mispellings, possible invalid DOIs which are all valid and not critical to the functioning of the package.

## Downstream dependencies
There are no known downstream dependencies
There are no known downstream dependencies on CRAN

0 comments on commit e9e7c8e

Please sign in to comment.