Skip to content
Permalink
Browse files

Remove pre-commit hook installation and setup

Add recommendation to use pre-commit hook
  • Loading branch information...
shreshthkhilani committed Feb 7, 2018
1 parent a5a5a24 commit 0c7b03df74ca80999f979b1279b195edcc57a50f
Showing with 13 additions and 5 deletions.
  1. +1 −0 .github/PULL_REQUEST_TEMPLATE.md
  2. +12 −0 README.markdown
  3. +0 −1 deployment/ansible/district-builder.yml
  4. +0 −4 scripts/setup
@@ -5,6 +5,7 @@ Brief description of what this PR does, and why it is needed.
### Checklist

- [ ] PR has a name that won't get you publicly shamed for vagueness
- [ ] Files changed in the PR have been `yapf`-ed for style violations

### Demo

@@ -98,3 +98,15 @@ Support
More information about the application settings, configuration information, and run-time information is available in the PublicMapping/DistrictBuilder [wiki](https://github.com/PublicMapping/DistrictBuilder/wiki).

Bug reports and feature requests can be reported to the PublicMapping/DistrictBuilder [issue tracker](https://github.com/PublicMapping/DistrictBuilder/issues).

Development
-----------

For development and contribution to this repo, it is recommended to install [pre-commit](https://pre-commit.com/) and setup the `yapf` hook as follows:

```bash
$ pip install pre-commit
$ pre-commit install
```

This will help with style of the Python code contributed to District Builder.
@@ -10,4 +10,3 @@
- { role: "azavea.python-security" }
- { role: "district-builder.docker" }
- { role: "district-builder.shellcheck" }
- { role: "district-builder.pre-commit" }
@@ -23,9 +23,5 @@ then
mkdir -p "${HOME}/.aws"

vagrant up --provision

# Sets up pre-commit hooks to yapf new python files.
pre-commit install

fi
fi

0 comments on commit 0c7b03d

Please sign in to comment.
You can’t perform that action at this time.