Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for Docker tags #534

Merged
merged 1 commit into from Feb 3, 2017
Merged

Add tests for Docker tags #534

merged 1 commit into from Feb 3, 2017

Conversation

elyezer
Copy link
Contributor

@elyezer elyezer commented Feb 2, 2017

Ensure that Pulp is able to create and update Docker tags, also ensure
that it can't create a tag to a manifest digest from another repository
and create a tag from an invalid manifest digest.

Close #436

Ensure that Pulp is able to create and update Docker tags, also ensure
that it can't create a tag to a manifest digest from another repository
and create a tag from an invalid manifest digest.

Close pulp#436
@elyezer
Copy link
Contributor Author

elyezer commented Feb 2, 2017

Tested on Pulp 2.12 on a RHEL7 server, tests passed as expected.

@coveralls
Copy link

coveralls commented Feb 2, 2017

Coverage Status

Coverage remained the same at 63.575% when pulling fafa0db on elyezer:fix-436 into db0c1c7 on PulpQE:master.

@daviddavis
Copy link
Contributor

Looks good 👍

return client.post(REPOSITORY_PATH, body)


def search_units(cfg, repo, criteria):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really need to move pulp_smash.tests.rpm.api_v2.utils.find_units to pulp_smash.utils.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@Ichimonji10 Ichimonji10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Tests pass on a matrix of six systems.

@Ichimonji10 Ichimonji10 merged commit 0819b30 into pulp:master Feb 3, 2017
@elyezer elyezer deleted the fix-436 branch February 6, 2017 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants