Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make build reproducible #485

Closed
jelly opened this issue Dec 7, 2019 · 1 comment
Closed

Make build reproducible #485

jelly opened this issue Dec 7, 2019 · 1 comment

Comments

@jelly
Copy link

jelly commented Dec 7, 2019

The current libcec cannot be built twice on different machines since it records the buildtime in the binary. A solution is to honour SOURCE_DATE_EPOCH which is described on the reproducible builds website https://reproducible-builds.org/
bmwiedemann added a commit to bmwiedemann/libcec that referenced this issue Dec 17, 2019
@bmwiedemann
Use cmake TIMESTAMP function
5fe1079 
to be more portable
and to allow for reproducible builds

See https://reproducible-builds.org/ for why this matters.

Also consistently use ISO 8601 date format to be understood everywhere.

Fixes Pulse-Eight#485
@bmwiedemann bmwiedemann mentioned this issue Dec 17, 2019
Closed
@bmwiedemann
Copy link
Contributor

in openSUSE we workaround it with
https://github.com/bmwiedemann/openSUSE/blob/master/packages/libc/libcec/libcec-build-compare.patch

but since it is cmake, one can use the TIMESTAMP macro to be more portable and provide reproducible builds at the same time. See #487 for that.

There are also build user, host and kernel version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use cmake TIMESTAMP function bmwiedemann/libcec
2 participants
@jelly @bmwiedemann