Fix self-host probe LLVM call typing after value-box property regression (#1080)#1097
Merged
Conversation
Restore typed object-property loadValue/operandJitType, narrow isValueOperand to TYPE_VALUE slots, unwrap value-box property slots to __object__* for native call args, and map VM null defaults for class properties. Co-authored-by: Cursor <cursoragent@cursor.com>
- Restore TYPE_OBJECT property loadValue/operandJitType paths - Native call: unwrap __value__ property slots to __object__* - Object identical compare via void* + ptrToInt - Stub isRedundantCoalesceTailAssign, all Superglobals, resolve() under self-host AOT Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
force-pushed
the
fix/1080-selfhost-probe-verify
branch
from
90a396d to
6c70656
Compare
This was referenced May 23, 2026
PurHur
added a commit
that referenced
this pull request
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loadValue/operandJitTypehandling for object property slots (TYPE_OBJECTvsTYPE_VALUE) after PR Fix JIT value boxing bitwise/unary/compare ops (#1069) #1080 (JIT: Value type bitwise/unary/compare ops (bootstrap-aot) #1069) regressed them to always cast as__value__*.__object__*when lowering native call arguments (fixesCompiler::operandsChainEqualverify failure).JitValueBox::isValueOperandtoTYPE_VALUEproperty slots only.TYPE_NULLinVariable::fromVMVariablefor nullable class property defaults.Root cause
PR #1080 removed the
TYPE_OBJECTbranch inHelper::loadValue, treating all non-string/hashtable property slots as__value__*. Operands passed to native methods expecting__object__*(e.g.operandsChainEqual) were lowered as__value__*, causing LLVM module verification to fail.Test plan
make bootstrap-selfhost-probe(passes Module verification; advances pastoperandsChainEqual)./script/bootstrap-selfhost-link.shmake bootstrap-wave-checkMade with Cursor