Fix bootstrap stdlib filesystem AOT under self-host stub gating (#1116)#1144
Merged
Conversation
9f18be5 to
f8473ff
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mkdir,file_put_contents,unlink, andrmdirinSelfHostBuiltinPolicy::CATEGORY_FILESYSTEMso they keep real JIT lowering whenPHP_COMPILER_SELFHOST_AOT=1(previously stubbed to no-opExternalMethod, producing00instead of11).BootstrapPhaseCTest::testStdlibFilesystemAotLinkAndExecutefor Phase C link+execute coverage.SelfHostBuiltinPolicyTestauto-stub batch count (32) and assert filesystem builtins are not stubbed.Closes #1116. Supersedes stale #1134 (fopen/fread/fclose landed via #1141).
Test plan
PHP_COMPILER_SELFHOST_AOT=1 php bin/compile.php -o /tmp/fs test/bootstrap-aot/stdlib_filesystem.php && /tmp/fs→11phpunit test/unit/SelfHostBuiltinPolicyTest.phpphpunit test/aot/BootstrapPhaseCTest.php --filter testStdlibFilesystem./script/bootstrap-aot-link.sh—stdlib_filesystem.phpnot in failure list (4 unrelated targets still failing on master)./script/ci-fast.sh --filter SelfHostBuiltinPolicyTestMade with Cursor