Fix MiniWebApp AOT POST contact thank-you execute (#485)#1148
Merged
Conversation
Render thank-you via direct thankyou.php include instead of nested layout→partial chain that SIGSEGVs in the native bundle; unskip MiniWebAppAotExecuteTest POST case and add AOT fixture. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
003-MiniWebAppPOST/contactSIGSEGV by rendering thank-you via directthankyou.phpinclude (nestedlayout.php→thankyou.phpchain segfaults in AOT multi-TU bundles)MiniWebAppAotExecuteTest::testPostQueryRouteContactThankYouand addminiwebapp_post_contactAOT fixtureTest plan
vendor/bin/phpunit --group miniwebapp-aot-execute(Docker)vendor/bin/phpunit --filter MiniWebAppVmCliTest(VM parity)vendor/bin/phpunit --filter miniwebapp_post_contactvendor/bin/phpunit --filter MiniWebAppUnskipMatrixTestCloses #485
Made with Cursor