Stdlib web batch: hash/preg verify + filter self-host AOT (#1119, #1121, #1122)#1150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filter_varandfilter_inputinSelfHostBuiltinPolicysoPHP_COMPILER_SELFHOST_AOT=1uses real JIT lowering instead of external stubs (Stdlib: filter_var + filter_input for web forms #1122).stdlib_hashandstdlib_pregalready pass AOT link and self-host AOT compile/run (Stdlib: hash() and hash_hmac() JIT/AOT #1119, Stdlib: preg_match JIT + bootstrap stdlib_preg #1121).script/audit-stdlib-jit.phpto recognizeJitFilter::lowering; audit now reports zero missing JIT builtins.Fixtures verified OK
PHP_COMPILER_SELFHOST_AOT=1)test/bootstrap-aot/stdlib_hash.phptest/bootstrap-aot/stdlib_preg.phptest/bootstrap-aot/stdlib_filter.php0mvs420mbefore policy fix)Test plan
./vendor/bin/phpunit --filter SelfHostBuiltinPolicyTeststdlib_hash,stdlib_preg,stdlib_filterunder self-host AOTmake bootstrap-selfhost-probe— still blocked by unrelatedConstStringFolderLLVM verify (Instruction does not dominate all uses!); not introduced by this PRCloses #1119, #1121, #1122
Made with Cursor